Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sengoku Basara - Graphical glitch (Android) #11931

Closed
Saramagrean opened this issue Mar 24, 2019 · 10 comments
Closed

Sengoku Basara - Graphical glitch (Android) #11931

Saramagrean opened this issue Mar 24, 2019 · 10 comments

Comments

@Saramagrean
Copy link
Contributor

What happens?

Graphics showing glitch, since v1.6.3-483-g1f881d790 (after Implement vertex range culling) occurs only in the OpenGL, on Vulkan is work well and happen on Android only.

1

What should happen?

Last work v1.6.3-468-gad6938de5 or v1.8.0 recent build with Vulkan.

2

What hardware, operating system, and PPSSPP version? On desktop, GPU matters for graphical issues.

Huawei P9+ (Kirin 955/Mali T-880/Android 8.0)

@unknownbrackets
Copy link
Collaborator

If I understand correctly, it's just the ground that is wrong, right? Interesting that it's OpenGL only - might mean that it's related to depth clamping in some way.

Could you try exporting a GE frame dump? These help a lot.

See here for instructions - it's not hard and works on Android too:
https://github.com/hrydgard/ppsspp/wiki/How-to-create-a-frame-dump

You can zip that and then drag and drop it into a reply here.

-[Unknown]

@Saramagrean
Copy link
Contributor Author

Yes, graphical glitch on the ground and here GE dump.
Dump (OGL).ppdmp.zip

Screenshot_PPSSPP_20190325-015158

@unknownbrackets
Copy link
Collaborator

For me, that's drawing correctly on all backends, so it may mean that's specific to Mali-T880. Just to confirm: you're using v1.8.0 or higher right? There were some fixes to range culling depth handling recently.

For reference, it should look like this:
NPJH50460_#11931_culling

-[Unknown]

@Saramagrean
Copy link
Contributor Author

Yes, I use PPSSPP v1.8.0-31-g8adb0dfd6.

@Saramagrean
Copy link
Contributor Author

Samsung J7 (Mali T-720) 😂
FB_IMG_1553463848371

@Saramagrean
Copy link
Contributor Author

Saramagrean commented Apr 9, 2019

Lord of Apocalypse get same problem too.
NPJH50503.ppdmp.zip

Screenshot_PPSSPP_20190410-021920

GE Dump 2
NPJH50503_2.ppdmp.zip

Screenshot_PPSSPP_20190410-023203

@unknownbrackets
Copy link
Collaborator

Strange. The draw happening there doesn't seem even close to being culled.

-[Unknown]

@Saramagrean
Copy link
Contributor Author

Saramagrean commented Jul 11, 2019

Enable DepthRangeHack for this game (or any game that encounter the same problem like Lord of Apocalypse, MGS:PW) It fixed graphical glitch on my device.

@Saramagrean
Copy link
Contributor Author

Saramagrean commented Aug 8, 2019

Okay, fixed by #12227

Thank you!! ヽ(´▽`)/

v1.8.0-429
Screenshot_PPSSPP_Luna_20190809-061010

v1.8.0-487
Screenshot_PPSSPP_20190809-061149

@unknownbrackets unknownbrackets added this to the v1.9.0 milestone Aug 8, 2019
@unknownbrackets
Copy link
Collaborator

Ah, great. Thanks for retesting and reporting.

-[Unknown]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants