Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android OpenSL initial queue fix #12333

Merged
merged 3 commits into from
Sep 17, 2019
Merged

Android OpenSL initial queue fix #12333

merged 3 commits into from
Sep 17, 2019

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Sep 17, 2019

Discovered (thanks to @jimmyw ) that I was queueing up the wrong amount of buffers and wrong size data when setting up OpenSL.

Fixing both issues and cleaning the code a little.

Android doesn't really seem to mind though, this doesn't appear to change anything about playback.

…startup.

I don't actually think this matters much though. Seems to make
absolutely no difference on any of my devices, but you never know.
…ttle data anyway (sizeof on dynamic buffer.. sigh).

Anyway like I said, none of this really seems to matter.
@hrydgard hrydgard added this to the v1.9.0 milestone Sep 17, 2019
@hrydgard hrydgard merged commit 07a5adc into master Sep 17, 2019
@jimmyw
Copy link
Contributor

jimmyw commented Sep 17, 2019

Thanks for the credit! :)

@ghost ghost mentioned this pull request Sep 19, 2019
@hrydgard hrydgard deleted the android-opensl-init-fix branch October 7, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants