Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mana Khemia 2 | Background Disappear During Conversation on Vulkan #12858

Closed
Spicy-Kimchi opened this issue Apr 27, 2020 · 7 comments
Closed
Labels
Depth / Z Issue involves depth drawing parameters.
Milestone

Comments

@Spicy-Kimchi
Copy link

Spicy-Kimchi commented Apr 27, 2020

What happens?

As mentioned in the title.

Vulkan
Screenshot_20200427-172234

OpenGL
Screenshot_20200427-172359

What hardware, operating system, and PPSSPP version? On desktop, GPU matters for graphical issues.

Huawei Mate 9 MHA-L29 | Kirin 960 Mali-G71 MP8 | Android 8.0.0

Dump.zip

@ghost
Copy link

ghost commented May 22, 2020

#12934 Has merge any improvement @C4rrotMilk ?

@unknownbrackets
Copy link
Collaborator

The game downloads the frame once, then stretches it to a 256x256 surface (both Mana Khemia and Mana Khemia 2 do this.)

The stretch is done with depth=32767, but this transforms to 0. Viewport scale/offset is -/+32500. Depth clamp is enabled.

Min Z is 0001, and max Z is fde8. Depth test is enabled and ALWAYS (same as STENCIL.) It does this to set stencil to 1 on each pixel during the stretch.

Because of the minz, it clips this and doesn't draw it.

Here's a dump of the actual draw - it's hacked together because it's the one frame, so ignore the repeating.
On a PSP, it does indeed draw:
ULJM05519_#12858_khemia2_dialog_black

We draw nothing, and in software rendering too. Maybe it's some precision issue in the transform?

Mana Khemia 1 draws a bit differently, when doing the same thing. It sets minz to 0 and transforms a bit differently.

-[Unknown]

@unknownbrackets unknownbrackets added the Depth / Z Issue involves depth drawing parameters. label May 23, 2020
@Spicy-Kimchi
Copy link
Author

Spicy-Kimchi commented May 29, 2020

Still the same in latest build. It's not really a big deal since I can play with OpenGL, just take your time :D

Edit: Confirmed fixed, I closing this.

@ghost
Copy link

ghost commented Jul 19, 2020

@C4rrotMilk issue is already fixed in what build of ppsspp?

@Spicy-Kimchi
Copy link
Author

v1.10.3-46-g6009bf7b7 #12952

@unknownbrackets
Copy link
Collaborator

Does it work on all backends? I thought there was still some depth issue.

-[Unknown]

@unknownbrackets unknownbrackets added this to the v1.11.0 milestone Jul 20, 2020
@Spicy-Kimchi
Copy link
Author

Didn't notice any issues on DX9 & DX11 as well. I will report if there got issues on other games. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Depth / Z Issue involves depth drawing parameters.
Projects
None yet
Development

No branches or pull requests

2 participants