Graphic issues in Syphon Filter Dark Mirror and Logan's Shadow

[Kayael76]

I'm not refering to #10229

• What happens ?

SFX like fire, flames and smoke don't display correctly. This YT video is from 2017 and not from me but it's still present in 1.10.3. Currently tried on my PC (W10 pro, i7 4790k, GTX 970) with every backend and tried ticking and unticking various performance hacks (thought it could be related to HW transform like #7306 but nope).

• How it looks now (note the explosion and the flames after) :

https://youtu.be/3xpdzI7K0wA?t=40

• How it should look :

https://youtu.be/h2Jg1BEIg7M?t=14

[hrydgard]

Can you generate and upload a GE frame dump? See instructions here: https://github.com/hrydgard/ppsspp/wiki/How-to-create-a-frame-dump

[Kayael76]

Sure, there you go :

recording.zip

Hope it worked correctly !

[hrydgard]

Thanks, it replays just fine! Unfortunately the problem was not as simple as I had hoped - I thought it might have been the mipmap blending trick seen in #6537, but it's doing just plain drawing with no fancy tricks, indicating that this is actually likely a CPU emulation bug :(

[ghost]

Also affects Resistance seems like its the same engine

[sum2012]

If I have time, I would try to make more exist value of the following table in Core/MIPS/MIPSVFPUUtils.cpp to test whether effect this game.

[sum2012]

Anyone with windows 64 bit
Please test this build
https://drive.google.com/file/d/1QOySqRLZmQwrHQQWNa_aOKgupUPGebDu/view?usp=sharing
This change: 3592a0f
Based on this table
https://www.mathcelebrity.com/anglebasic.php?entry=210&coff=&pl=sin

[hrydgard]

Those are probably not gonna do much and are unfortunately wrong - remember, angle here is not a normal radians angle that goes from 0 to 2*PI, it goes from 0 to 4 for the full circle.

[Kayael76]

I gave it a try but no, it doesn't work as intended. Thanks for trying though !

[sum2012]

@hrydgard ok

[sum2012]

Can anyone try again with windows 64 bit ?
https://drive.google.com/file/d/1O7EoOxVH5L_kCVLgsqvm3KiFu22dZIFh/view?usp=sharing
This apply special angle and double precision

[Kayael76]

I tried but no changes unfortunately.

[Panderner]

Maybe related to #10165

[Panderner]

PPSSPP v1.12.3-1237-g6125c9765 software render:

[unknownbrackets]

So, that also looks wrong, right? Sounds more like it's a CPU bug indeed...

-[Unknown]

[Panderner]

Incorrect graphic effects can cause crashes due to CPU bug, It effects Logan's Shadow and Resistance.

[Panderner]

Software renderer + Interpreter still happen:

[LeyoSFO]

@hrydgard hi, is there hope to fix this issue? it's still happening in both Syphon Filters Dark Mirror and Logan's Shadow PPSSPP 1.15.4

[Panderner]

Here's the screenshot recorded from PS5:

[Panderner]

The fire behavior is correct for Emulated PS5 and PS4 version.

[LeyoSFO]

reporting, this still occurs in 1.17.1