Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable analog head size #14480

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Configurable analog head size #14480

merged 2 commits into from
Sep 13, 2021

Conversation

iota97
Copy link
Contributor

@iota97 iota97 commented May 24, 2021

Change the default a bit as now you have to press on the head to get the input (before pressing on the background would move the stick as well).

Also add a checkbox to disable the stick background if someone want to scale it pretty big (it's still being drawn in the layout editor to give feedback).

@LunaMoo
Copy link
Collaborator

LunaMoo commented May 24, 2021

Change the default a bit as now you have to press on the head to get the input (before pressing on the background would move the stick as well).

Don't think changing the default of something like that is a good idea a lot of people who actually use only touch controls might be used to simply clicking on the side instead of having to click on the center before allowed to drag.

@iota97
Copy link
Contributor Author

iota97 commented May 24, 2021

You got quite a point.

I guess it's possible to make the head collision a bit larger than the image to match the default. Not sure how much relevant is if the image is off of a 15% or so tho'.

@hrydgard
Copy link
Owner

This needs a rebase.

I'd like the default to not change behavior or look at all, and I'm not sure if it makes sense to have separate settings for left and right stick, given how rare second stick usage is.

@hrydgard hrydgard added the Input/Controller Input and controller issues label Jul 11, 2021
@hrydgard hrydgard added this to the v1.12.0 milestone Jul 11, 2021
@iota97
Copy link
Contributor Author

iota97 commented Jul 12, 2021

Rebased and made the default the same (just to note in master the stick "collision" size ignored the scale so I fixed that).

About having 2 different setting for right and left I would just find confusing if changing an analog would change both in the layout screen. I can make them the same if you prefer tho', I got the bad habits of adding too many setting xD

@unknownbrackets
Copy link
Collaborator

I think having separate settings for left and right makes sense, given that the right analog sizing is within the control management anyway.

-[Unknown]

@hrydgard hrydgard merged commit c333e2b into hrydgard:master Sep 13, 2021
@iota97 iota97 deleted the analog-head branch September 13, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Input/Controller Input and controller issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants