Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

softgpu: Ensure early depth test uses SIMD #17621

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

unknownbrackets
Copy link
Collaborator

It's a bit unfortunate to split this out of the main depth test func as it adds ~100 lines, but this seems to improve FPS for me in software rendering by around 5% (depending on game) in 3D games, so seems worth it.

-[Unknown]

@hrydgard
Copy link
Owner

For an independent 5% improvement, definitely seems worth the added complexity.

@hrydgard hrydgard merged commit f02ccfc into hrydgard:master Jun 25, 2023
@unknownbrackets unknownbrackets deleted the softgpu-opt-z branch June 25, 2023 18:28
@hrydgard
Copy link
Owner

hrydgard commented Oct 9, 2023

This is reported to crash in Crazy Taxi, I guess memory slightly out of bounds..

@unknownbrackets
Copy link
Collaborator Author

unknownbrackets commented Oct 10, 2023

Hm, if the crash started with this, I guess it'd have to be alignment? Or actually, these don't have alignment requirements.

It would've crashed before too if x/y went outside VRAM. Which shouldn't really happen here, since the render target ought to be masked to the first 2MB anyway. But also the alignment ought to be safe because the render target should mask that too.

Seems there's a frame dump, will see if I have some time to look...

-[Unknown]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants