Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: Fix errors on connect #18205

Merged
merged 1 commit into from
Sep 23, 2023
Merged

Conversation

unknownbrackets
Copy link
Collaborator

The error logging and error checks weren't right, especially on Windows.

-[Unknown]

@hrydgard
Copy link
Owner

hrydgard commented Sep 23, 2023

Thanks for clearing this stuff up!

I'm just gonna get it in, should be safe enough with some cursory testing.

@hrydgard hrydgard added this to the v1.16.4 milestone Sep 23, 2023
@hrydgard hrydgard merged commit a829578 into hrydgard:master Sep 23, 2023
18 checks passed
@unknownbrackets unknownbrackets deleted the http-error branch September 23, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants