Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix-VX-Responsive-ScaleSVG-PropTypes #408

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Fix-VX-Responsive-ScaleSVG-PropTypes #408

merged 1 commit into from
Jan 9, 2019

Conversation

mmarkelov
Copy link

🐛 Bug Fix

I got warning with ScaleSVG component:

import { ScaleSVG } from "@vx/responsive";
...
      <ScaleSVG width={400} height={200}>
        <LineRadial width={500} height={200} />
      </ScaleSVG>
...

Edit 98yx2qvryp

Warning: Failed prop type: Invalid prop `children` of type `object` supplied to `n`, expected `function`.

So I suppose it should be PropTypes.any for ScaleSVG component

@hshoff hshoff added this to the v0.0.184 milestone Jan 9, 2019
@hshoff hshoff added the 🐛 bug label Jan 9, 2019
hshoff
hshoff approved these changes Jan 9, 2019
View reviewed changes
Copy link
Member

@hshoff hshoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for the PR

@hshoff hshoff merged commit 0c6ec06 into airbnb:master Jan 9, 2019
@snyk-bot snyk-bot mentioned this pull request Jan 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hshoff hshoff hshoff approved these changes

Assignees
No one assigned
Labels
🐛 bug
Projects
None yet
Milestone
v0.0.184
Development

Successfully merging this pull request may close these issues.
2 participants
@mmarkelov @hshoff