Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shape] add arc prop undefined checks. fixes #462 #464

Merged
merged 1 commit into from
May 16, 2019
Merged

[shape] add arc prop undefined checks. fixes #462 #464

merged 1 commit into from
May 16, 2019

Conversation

hshoff
Copy link
Member

@hshoff hshoff commented May 16, 2019

💥 Breaking Changes

  • [shape] <Arc /> and <Pie pieValue={} /> props now check for !== undefined. Before 0 wouldn't set the prop to 0 because if (0) is false. This is only a breaking change if you were passing 0 before and happy with <Arc /> treating that as undefined and using d3.arc() defaults.

🐛 Bug Fix

  • [shape] <Arc /> now respects 0 as an allowed prop value
  • [shape] <Pie /> pieValue now respects 0 as an allowed prop value

🏠 Internal

  • [shape] add more <Arc /> tests
  • [shape] convert Arc.test from CRLF => LF

@hshoff hshoff added this to the v0.0.189 milestone May 16, 2019
@hshoff hshoff merged commit b4b0bf8 into master May 16, 2019
@hshoff hshoff deleted the harry-fix-arc branch May 16, 2019 17:44
@snyk-bot snyk-bot mentioned this pull request Jan 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.0.189
Development

Successfully merging this pull request may close these issues.
1 participant
@hshoff