-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make --tls
option and have --ssl
be an alias for it
#588
Comments
@thornjad: Is this issue still relevant? I have been meaning to get back into OSS & this seemed like an easy win. :) |
Yeah, this is still outstanding, go for it! |
@thornjad: Looks like @dalgleish already beat me to it. :) |
Closed
This issue has been inactive for 180 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A small pet peeve of mine is that the
--ssl
option enables TLS, not SSL. I accept that the tech world uses these related but different terms interchangeably, but I'd rather be more correct by default.To do:
--ssl
option with--tls
.a. Note that this enables "TLS/SSL" in the documentation so it doesn't confuse people.
b. The short option
-S
could stay the same, having it stand for "Secure".--ssl
option as an alias for--tls
.a. Note in the documentation that it's an alias
b. In the code, if
ssl
is specified, translate it directly into thetls
option.c. If for some reason the user specifies both options, like
--tls --no-ssl
, consider--tls
to be the authoritative option (i.e. allow thetls
option to overridessl
).The text was updated successfully, but these errors were encountered: