Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is PySocks a dependancy ? #990

Closed
stonebig opened this issue Nov 11, 2020 · 5 comments
Closed

is PySocks a dependancy ? #990

stonebig opened this issue Nov 11, 2020 · 5 comments

Comments

@stonebig
Copy link

stonebig commented Nov 11, 2020

With pip-20.3 new resolver coming, pysocks is enterpreted as mandatory dependancy from your https://github.com/httpie/httpie/blob/master/setup.py#L40..L41

install_requires = [
    'requests[socks]>=2.22.0',`

Is it what you wanted ?

( maybe it's a bug, not clear to me what the truth shall be: pypa/pip#9112 (comment))

@jkbrzt
Copy link
Member

jkbrzt commented Dec 21, 2020

@stonebig yes, this is intentional so that SOCKS support comes out of the box, and the user doesn’t have to install PySocks manually. Is it causing any issues?

@stonebig
Copy link
Author

Not directly, it's just the Way you specify it in setup.py is imperfectly managed in pip toolset

@BoboTiG
Copy link
Contributor

BoboTiG commented Sep 22, 2021

@stonebig do you have all answers you had looked for?

@isidentical
Copy link
Contributor

Closing as the question was answered, @stonebig if you have any more questions feel free to create new issues.

@stonebig
Copy link
Author

Sorry, I forgot to Close. Happy new Year to the team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants