Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent header renaming? #317

Closed
mhenrixon opened this issue Mar 15, 2016 · 6 comments
Closed

Prevent header renaming? #317

mhenrixon opened this issue Mar 15, 2016 · 6 comments

Comments

@mhenrixon
Copy link

How can I prevent header renaming? I need to provide headers with an underscore and I can't find a way to achieve this.

@ixti
Copy link
Member

ixti commented Mar 15, 2016

Can you explain why you might need this?

@ixti
Copy link
Member

ixti commented Mar 15, 2016

You're not the first one who was asking this question, so I'm pretty concerned if this is really needed feature (we can probably allow pass header names without normalization)

@mhenrixon
Copy link
Author

For me it turned out it wasn't needed I just thought it was when I got different errors from CURL when I changed the name of the headers.

@ixti
Copy link
Member

ixti commented Mar 15, 2016

Ah. OK. Thanks.

@tarcieri
Copy link
Member

I think in general the way we process headers could use some work (and was a regression from my previous code). We always do duplicate allocations for headers, even if they already match the canonical format.

I think we should check first if they match the canonical format, in which case the duplicate allocations should be skipped. Right now we always check and always allocate.

@ixti
Copy link
Member

ixti commented Mar 16, 2016

was a regression from my previous code

Fixed in: #318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants