String Manipulation and Comparison Operations #341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -68,13 +68,13 @@ def perform(request, response) | |||
| # Check if we reached max amount of redirect hops | |||
| # @return [Boolean] | |||
| def too_many_hops? | |||
| 1 <= @max_hops && @max_hops < @visited.count | |||
| @max_hops > 0 && @visited.count > @max_hops | |||
There was a problem hiding this comment.
I think @visited.size or @visited.length would be more descriptive here.
|
Agree with |
| @@ -43,7 +43,7 @@ def coerce(object) | |||
| # @param [#to_s] str | |||
| # @return [Symbol] | |||
| def symbolize(str) | |||
| str.to_s.downcase.tr("-", " ").gsub(/[^a-z ]/, "").gsub(/\s+/, "_").to_sym | |||
| str.to_s.downcase.tr("- ", "_").delete("^a-z_").to_sym | |||
There was a problem hiding this comment.
[1] pry(main)> "Bad request".downcase.tr("- ", "_").delete("^a-z_").to_sym
=> :bad__request
[2] pry(main)> "Bad request".downcase.tr("-", " ").gsub(/[^a-z ]/, "").gsub(/\s+/, "_").to_sym
=> :bad_request
|
Partially merged in 015a707 |
|
@ixti Thanks for the quick feedback. I'm just curious, what are your objections to swapping the variables? |
|
Well, mostly pretty subjective personal vision of beauty :D I prefer to see constants on the left of expression. I guess this is actually the only reason :D after all... |
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Oct 18, 2016
## 2.0.3 (2016-08-03) * [#365](httprb/http#365) Add `HTTP::Response#content_length` ([@janko-m]) * [#335](httprb/http#335), [#360](httprb/http#360) Set `Content-Length: 0` header for `nil` bodies. ([@britishtea]) ## 2.0.2 (2016-06-24) * [#353](httprb/http#353) Avoid a dependency cycle between Client and Connection classes. ([@jhbabon]) ## 2.0.1 (2016-05-12) * [#341](httprb/http#341) Refactor some string manipulations so they are more performant (up to 3-4x faster) and more concise. ([@tonyta]) * [#339](httprb/http#341) Always use byte methods when writing/slicing the write buffer. ([@zanker]) ## 2.0.0 (2016-04-23) * [#333](httprb/http#333) Fix HTTPS request headline when sent via proxy. ([@Connorhd]) * [#331](httprb/http#331) Add `#informational?`, `#success?`, `#redirect?`, `#client_error?` and `#server_error?` helpers to `Response::Status`. ([@mwitek]) * [#330](httprb/http#330) Support custom CONNECT headers (request/response) during HTTPS proxy requests. ([@smudge]) * [#319](httprb/http#319) Drop Ruby 1.9.x support. ([@ixti]) ## 1.0.4 (2016-03-19) * [#320](httprb/http#320) Fix timeout regression. ([@tarcieri]) ## 1.0.3 (2016-03-16) * [#314](httprb/http#314) Validate charset before forcing encoding. ([@kylekyle]) * [#318](httprb/http#318) Remove redundant string allocations upon header names normalization. ([@ixti])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again!
I thought I'd suggest some changes after reading through this beautiful source!
Changes:
Hope this is helpful! 😸