From e37b2a402ac88710a4c05b1d49526c4f4e48bcd9 Mon Sep 17 00:00:00 2001 From: Sergey Shandar Date: Wed, 15 Nov 2017 15:12:14 -0800 Subject: [PATCH] Policy => Strategy --- .../Commands.Common.Strategies.csproj | 6 +-- ...ResourcePolicy.cs => IResourceStrategy.cs} | 2 +- .../NestedResourceConfig.cs | 8 ++-- ...rcePolicy.cs => NestedResourceStrategy.cs} | 10 ++--- .../ResourceConfig.cs | 8 ++-- ...{ResourcePolicy.cs => ResourceStrategy.cs} | 44 +++++++++---------- .../Compute/AzureRM.Compute.psd1 | 2 +- 7 files changed, 40 insertions(+), 40 deletions(-) rename src/ResourceManager/Common/Commands.Common.Strategies/{IResourcePolicy.cs => IResourceStrategy.cs} (64%) rename src/ResourceManager/Common/Commands.Common.Strategies/{NestedResourcePolicy.cs => NestedResourceStrategy.cs} (72%) rename src/ResourceManager/Common/Commands.Common.Strategies/{ResourcePolicy.cs => ResourceStrategy.cs} (54%) diff --git a/src/ResourceManager/Common/Commands.Common.Strategies/Commands.Common.Strategies.csproj b/src/ResourceManager/Common/Commands.Common.Strategies/Commands.Common.Strategies.csproj index 8779883533bf..800230795777 100644 --- a/src/ResourceManager/Common/Commands.Common.Strategies/Commands.Common.Strategies.csproj +++ b/src/ResourceManager/Common/Commands.Common.Strategies/Commands.Common.Strategies.csproj @@ -73,14 +73,14 @@ - + - + - + diff --git a/src/ResourceManager/Common/Commands.Common.Strategies/IResourcePolicy.cs b/src/ResourceManager/Common/Commands.Common.Strategies/IResourceStrategy.cs similarity index 64% rename from src/ResourceManager/Common/Commands.Common.Strategies/IResourcePolicy.cs rename to src/ResourceManager/Common/Commands.Common.Strategies/IResourceStrategy.cs index 8c5c93e2cf0d..1181c6415f91 100644 --- a/src/ResourceManager/Common/Commands.Common.Strategies/IResourcePolicy.cs +++ b/src/ResourceManager/Common/Commands.Common.Strategies/IResourceStrategy.cs @@ -1,6 +1,6 @@ namespace Microsoft.Azure.Commands.Common.Strategies { - public interface IResourcePolicy + public interface IResourceStrategy { } } diff --git a/src/ResourceManager/Common/Commands.Common.Strategies/NestedResourceConfig.cs b/src/ResourceManager/Common/Commands.Common.Strategies/NestedResourceConfig.cs index 4bacb105a091..c89de9f6d467 100644 --- a/src/ResourceManager/Common/Commands.Common.Strategies/NestedResourceConfig.cs +++ b/src/ResourceManager/Common/Commands.Common.Strategies/NestedResourceConfig.cs @@ -7,20 +7,20 @@ namespace Microsoft.Azure.Commands.Common.Strategies public static class NestedResourceConfig { public static NestedResourceConfig CreateConfig( - this NestedResourcePolicy policy, + this NestedResourceStrategy strategy, IResourceConfig parent, string name, Func create) where Model : class where ParentModel : class - => new NestedResourceConfig(policy, parent, name, create); + => new NestedResourceConfig(strategy, parent, name, create); } public sealed class NestedResourceConfig : IResourceConfig where Model : class where ParentModel : class { - public NestedResourcePolicy Policy { get; } + public NestedResourceStrategy Policy { get; } public string Name { get; } @@ -29,7 +29,7 @@ public sealed class NestedResourceConfig : IResourceConfig CreateModel { get; } public NestedResourceConfig( - NestedResourcePolicy policy, + NestedResourceStrategy policy, IResourceConfig parent, string name, Func createModel) diff --git a/src/ResourceManager/Common/Commands.Common.Strategies/NestedResourcePolicy.cs b/src/ResourceManager/Common/Commands.Common.Strategies/NestedResourceStrategy.cs similarity index 72% rename from src/ResourceManager/Common/Commands.Common.Strategies/NestedResourcePolicy.cs rename to src/ResourceManager/Common/Commands.Common.Strategies/NestedResourceStrategy.cs index cf4dabce0224..5351f184731c 100644 --- a/src/ResourceManager/Common/Commands.Common.Strategies/NestedResourcePolicy.cs +++ b/src/ResourceManager/Common/Commands.Common.Strategies/NestedResourceStrategy.cs @@ -3,7 +3,7 @@ namespace Microsoft.Azure.Commands.Common.Strategies { - public sealed class NestedResourcePolicy : IResourcePolicy + public sealed class NestedResourceStrategy : IResourceStrategy { public Func> GetId { get; } @@ -11,7 +11,7 @@ public sealed class NestedResourcePolicy : IResourcePolicy public Action Set { get; } - public NestedResourcePolicy( + public NestedResourceStrategy( Func> getId, Func get, Action set) @@ -22,15 +22,15 @@ public NestedResourcePolicy( } } - public static class NestedResourcePolicy + public static class NestedResourceStraegy { - public static NestedResourcePolicy Create( + public static NestedResourceStrategy Create( string header, Func get, Action set) where Model : class where ParentModel : class - => new NestedResourcePolicy( + => new NestedResourceStrategy( name => new[] { header, name}, get, set); diff --git a/src/ResourceManager/Common/Commands.Common.Strategies/ResourceConfig.cs b/src/ResourceManager/Common/Commands.Common.Strategies/ResourceConfig.cs index 0c2de28a72f3..b90933d16088 100644 --- a/src/ResourceManager/Common/Commands.Common.Strategies/ResourceConfig.cs +++ b/src/ResourceManager/Common/Commands.Common.Strategies/ResourceConfig.cs @@ -8,7 +8,7 @@ namespace Microsoft.Azure.Commands.Common.Strategies public sealed class ResourceConfig : IResourceConfig where Model : class { - public ResourcePolicy Policy { get; } + public ResourceStrategy Policy { get; } public string ResourceGroupName { get; } @@ -19,7 +19,7 @@ public sealed class ResourceConfig : IResourceConfig public IEnumerable Dependencies { get; } public ResourceConfig( - ResourcePolicy policy, + ResourceStrategy policy, string resourceGroupName, string name, Func createModel, @@ -49,7 +49,7 @@ public IEnumerable GetId(string subscription) public static class ResourceConfig { public static ResourceConfig CreateConfig( - this ResourcePolicy policy, + this ResourceStrategy policy, string resourceGroupName, string name, Func createModel = null, @@ -63,7 +63,7 @@ public static ResourceConfig CreateConfig( dependencies.EmptyIfNull()); public static ResourceConfig CreateConfig( - this ResourcePolicy policy, + this ResourceStrategy policy, ResourceConfig resourceGroup, string name, Func createModel = null, diff --git a/src/ResourceManager/Common/Commands.Common.Strategies/ResourcePolicy.cs b/src/ResourceManager/Common/Commands.Common.Strategies/ResourceStrategy.cs similarity index 54% rename from src/ResourceManager/Common/Commands.Common.Strategies/ResourcePolicy.cs rename to src/ResourceManager/Common/Commands.Common.Strategies/ResourceStrategy.cs index 9b59c28973e7..55f5572eae2f 100644 --- a/src/ResourceManager/Common/Commands.Common.Strategies/ResourcePolicy.cs +++ b/src/ResourceManager/Common/Commands.Common.Strategies/ResourceStrategy.cs @@ -5,24 +5,24 @@ namespace Microsoft.Azure.Commands.Common.Strategies { - public sealed class ResourcePolicy : IResourcePolicy + public sealed class ResourceStrategy : IResourceStrategy { public Func> GetId { get; } - public Func, Task> GetAsync { get; } + public Func, Task> GetAsync { get; } - public Func, Task> CreateOrUpdateAsync { get; } + public Func, Task> CreateOrUpdateAsync { get; } - public Func GetLocation { get; } + public Func GetLocation { get; } - public Action SetLocation { get; } + public Action SetLocation { get; } - public ResourcePolicy( + public ResourceStrategy( Func> getId, - Func, Task> getAsync, - Func, Task> createOrUpdateAsync, - Func getLocation, - Action setLocation) + Func, Task> getAsync, + Func, Task> createOrUpdateAsync, + Func getLocation, + Action setLocation) { GetId = getId; GetAsync = getAsync; @@ -32,19 +32,19 @@ public ResourcePolicy( } } - public static class ResourcePolicy + public static class ResourceStrategy { - public static ResourcePolicy Create( + public static ResourceStrategy Create( Func> getId, Func getOperations, - Func, Task> getAsync, - Func, Task> createOrUpdateAsync, - Func getLocation, - Action setLocation) + Func, Task> getAsync, + Func, Task> createOrUpdateAsync, + Func getLocation, + Action setLocation) where Client : class, IDisposable { Func toOperations = client => getOperations(client.GetClient()); - return new ResourcePolicy( + return new ResourceStrategy( getId, p => getAsync(GetAsyncParams.Create( toOperations(p.Operations), p.ResourceGroupName, p.Name, p.CancellationToken)), @@ -54,13 +54,13 @@ public static ResourcePolicy Create( setLocation); } - public static ResourcePolicy Create( + public static ResourceStrategy Create( IEnumerable headers, Func getOperations, - Func, Task> getAsync, - Func, Task> createOrUpdateAsync, - Func getLocation, - Action setLocation) + Func, Task> getAsync, + Func, Task> createOrUpdateAsync, + Func getLocation, + Action setLocation) where Client : class, IDisposable => Create( name => new[] { "providers" }.Concat(headers).Concat(new[] { name }), diff --git a/src/ResourceManager/Compute/AzureRM.Compute.psd1 b/src/ResourceManager/Compute/AzureRM.Compute.psd1 index bd9a1d81fa01..2d881ebb9bda 100644 --- a/src/ResourceManager/Compute/AzureRM.Compute.psd1 +++ b/src/ResourceManager/Compute/AzureRM.Compute.psd1 @@ -54,7 +54,7 @@ CLRVersion = '4.0' RequiredModules = @(@{ModuleName = 'AzureRM.Profile'; ModuleVersion = '3.3.1'; }) # Assemblies that must be loaded prior to importing this module -# RequiredAssemblies = @() +RequiredAssemblies = @('Microsoft.Azure.Commands.Common.Strategies') # Script files (.ps1) that are run in the caller's environment prior to importing this module. # ScriptsToProcess = @()