Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to set repository topics #594

Merged
merged 2 commits into from
Nov 7, 2019

Conversation

martinvanzijl
Copy link
Contributor

Fixes #546.

  • Added (i.e. un-commented) the method GHRepository.setTopics, which is working now.
  • Added test cases testSetTopics and testSetTopicsEmpty.
  • Removed testListTopics, since this is covered by the two tests above, and also may fail depending on what order the tests run in.

Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took the tests one step further. Thanks!

@bitwiseman bitwiseman merged commit 9cecce7 into hub4j:master Nov 7, 2019
@martinvanzijl martinvanzijl deleted the add-method-to-set-topics branch November 8, 2019 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage repository topics
2 participants