Writing custom check functions vignette #127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'main' into ak/custom-fn-dev-article/121 # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
annakrystalli
commented
Oct 4, 2024
| echo 'dir=./docs/dev' >> $GITHUB_OUTPUT | ||
| else | ||
| echo 'dir=./docs' >> $GITHUB_OUTPUT | ||
| fi | ||
| - name: Deploy PR preview to Netlify |
There was a problem hiding this comment.
These changes fix broken dev previews URLs resulting from the fact we've got both release and dev versions of docs now
annakrystalli
commented
Oct 4, 2024
| check_for_errors(validate_submission(hub_path, file_path)), | ||
| check_for_errors(validate_submission( | ||
| hub_path, file_path, | ||
| skip_submit_window_check = TRUE |
There was a problem hiding this comment.
Just fixing an oversight in a previously added test that was now returning a submission window check error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
I've also pulled out information that is useful to both the writing and deploying custom functions vignette into children documents which are now deployed in both. Because of this it might be more useful to have the rendered vignette open to see the content in place.