Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] fix: retain memory utility. #9543

Merged
merged 6 commits into from
Sep 28, 2024
Merged

Conversation

sayakpaul
Copy link
Member

What does this PR do?

My bad that in

def clear_objs_and_retain_memory(objs: List[Any]):

I assumed that the scope of del would carry forward but that is not the case. So, even when we call del obj it actually just deletes the local reference, it doesn't carry forward. So, we're better off without it and doing del explicitly (like the changes done in this PR).

Thanks to @a-r-r-o-w for catching this. It didn't go to a release yet, so, I think this shouldn't have any issues.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lightning fast fix, thanks! I'm not sure about the name retain_memory though, as retain means to keep something as-is. Maybe free_memory or something would be better? No problem if not though

@sayakpaul
Copy link
Member Author

I had a different meaning in mind, don't know why. But I get your point. Will rename to free_memory() as it makes more sense, of course.

@sayakpaul sayakpaul merged commit 8e7d6c0 into main Sep 28, 2024
18 checks passed
@sayakpaul sayakpaul deleted the fix-retain-memory-utility branch September 28, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants