Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slack sender] The channel argument is redundant with the webhook_url argument #51

Open
martinp7 opened this issue Mar 27, 2020 · 0 comments

Comments

@martinp7
Copy link

martinp7 commented Mar 27, 2020

First of all thanks for the work !

It seems the channel argument is redundant with the webhook_url argument since the creation of a Slack webhook URL requires a channel : the information of the channel is included in the webhook

TODO :

  • remove the argument channel, to avoid breaking change it can set to optional argument instead
  • update the slack section of the README.md

@VictorSanh if you are OK with this, I can do the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant