Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document what layerdrop does #23351

Closed
3 of 4 tasks
RobertBaruch opened this issue May 13, 2023 · 4 comments
Closed
3 of 4 tasks

Document what layerdrop does #23351

RobertBaruch opened this issue May 13, 2023 · 4 comments

Comments

@RobertBaruch
Copy link
Contributor

System Info

  • transformers version: 4.28.1
  • Platform: Windows-10-10.0.22621-SP0
  • Python version: 3.11.2
  • Huggingface_hub version: 0.14.1
  • Safetensors version: not installed
  • PyTorch version (GPU?): 2.0.1+cu117 (True)
  • Tensorflow version (GPU?): not installed (NA)
  • Flax version (CPU?/GPU?/TPU?): not installed (NA)
  • Jax version: not installed
  • JaxLib version: not installed
  • Using GPU in script?: NO
  • Using distributed or parallel set-up in script?: NO

Who can help?

@sgugger

Information

  • The official example scripts
  • My own modified scripts

Tasks

  • An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
  • My own task or dataset (give details below)

Reproduction

In transformers/models/wav2vec2/configuration_wav2vec2.py there is a parameter layerdrop in __init__ which is not documented. This parameter is set (and overrides the default 0.1) in the examples at examples/pytorch/speech-recognition/README.md, so it seems to be important.

Expected behavior

Document layerdrop.

@amyeroberts
Copy link
Collaborator

cc @sanchit-gandhi

@sanchit-gandhi
Copy link
Contributor

Hey @RobertBaruch - good catch! It's indeed missing from the Wav2Vec2 config docstring. Would you like to open a PR to add this info? Easiest would be to copy the details from one of the existing configs where the info is present, e.g. OPT:

layerdrop: (`float`, *optional*, defaults to 0.0):

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@sanchit-gandhi
Copy link
Contributor

Closed via #23691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants