Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HfDeepSpeedConfig + ZeRO3 init accuracy bug! #28596

Closed
4 tasks done
hijkzzz opened this issue Jan 19, 2024 · 5 comments
Closed
4 tasks done

HfDeepSpeedConfig + ZeRO3 init accuracy bug! #28596

hijkzzz opened this issue Jan 19, 2024 · 5 comments

Comments

@hijkzzz
Copy link

hijkzzz commented Jan 19, 2024 •
edited
Loading

System Info

see microsoft/DeepSpeed#4932

Who can help?

No response

Information

  • The official example scripts
  • My own modified scripts

Tasks

  • An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
  • My own task or dataset (give details below)

Reproduction

microsoft/DeepSpeed#4932

Expected behavior

microsoft/DeepSpeed#4932
@hijkzzz
Copy link
Author

hijkzzz commented Jan 19, 2024 •
edited
Loading

microsoft/DeepSpeed#4932

@hijkzzz hijkzzz changed the title HfDeepSpeedConfig accuracy bug! HfDeepSpeedConfig + ZeRO3 init accuracy bug! Jan 19, 2024
@amyeroberts
Copy link
Collaborator

Hi @hijkzzz, thanks for raising an issue!

cc @pacman100 @ArthurZucker cf this comment

@ArthurZucker
Copy link
Collaborator

Also cc @gante as it seems related to ROPE!

@rwightman rwightman mentioned this issue Jan 24, 2024
Closed
4 tasks
@gante
Copy link
Member

gante commented Jan 27, 2024

To prevent duplication, let's focus all discussion on #28685 🤗

@gante gante mentioned this issue Feb 2, 2024
Closed
@huggingface huggingface deleted a comment from github-actions bot Feb 21, 2024
@huggingface huggingface deleted a comment from github-actions bot Mar 18, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@hijkzzz hijkzzz closed this as completed Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@gante @hijkzzz @amyeroberts @ArthurZucker