Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDPA implementation to more models #33171

Closed
avishaiElmakies opened this issue Aug 28, 2024 · 5 comments
Closed

Add SDPA implementation to more models #33171

avishaiElmakies opened this issue Aug 28, 2024 · 5 comments
Labels
Feature request Request for a new feature

Comments

@avishaiElmakies
Copy link
Contributor

Feature request

many of the newer models have an sdpa implementation. It could be good that some of the older models get up to speed.

Motivation

this could be good to unify the API more.
and improve training\inference speed for some of the older models like OPT.

Your contribution

Might be able to help with a few. this one seems bigger than the other feature request i opened, so will probably need more help

@avishaiElmakies avishaiElmakies added the Feature request Request for a new feature label Aug 28, 2024
@LysandreJik
Copy link
Member

Hey @avishaiElmakies, this seems like a duplicate of #26350

We'd very much welcome some SDPA additions 🤗

@avishaiElmakies
Copy link
Contributor Author

@LysandreJik, it says flash attention. So I thought it was a different thing 😅. You can close this if you consider them the same issue. I will try to work on some models in my free time.

@vasqu
Copy link
Contributor

vasqu commented Aug 28, 2024

It's #28005 ;)

@avishaiElmakies
Copy link
Contributor Author

Thanks

@LysandreJik
Copy link
Member

Thanks @vasqu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

3 participants