Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tests #89

Closed
luke- opened this issue Nov 26, 2021 · 5 comments
Closed

Fix Tests #89

luke- opened this issue Nov 26, 2021 · 5 comments
Assignees

Comments

@luke-
Copy link
Contributor

luke- commented Nov 26, 2021

No description provided.

@yurabakhtin
Copy link
Contributor

@luke- PR #90.
Please note the test errors look strange because locally I couldn't reproduce them, and only after several tryings(you can find 5 commits there) I could get the test checks without errors, but I am not sure they will not appear in future.

@luke-
Copy link
Contributor Author

luke- commented Nov 29, 2021

@yurabakhtin Ok, thanks!

@luke- luke- closed this as completed Nov 29, 2021
@luke-
Copy link
Contributor Author

luke- commented Nov 29, 2021

@luke- luke- reopened this Nov 29, 2021
@yurabakhtin
Copy link
Contributor

@luke- As I wrote above "I am not sure they will not appear in future", I mean the errors are float i.e. sometimes the tests run without errors like you can see for the 3 first cases: PHP 7.4 + develop, PHP 7.4 + master, PHP 8.0 + develop, but the last PHP 8.0 + master is broken by some unknown reason. Even if you see the errors, it looks like old/cached code is executed:

test_code

On my local server I cannot reproduce the errors:
gallery_test

Do you have any idea? Maybe some temp problems on the server where the tests are executed...

@luke-
Copy link
Contributor Author

luke- commented Nov 30, 2021

@yurabakhtin I tried this: 03471a2
Currently the tests are running and I don't see a impact on the speed/duration with my change.
Let's keep monitoring it.

@luke- luke- closed this as completed Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants