Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow password manager app to auto-fill the login form #89

Open
marc-farre opened this issue Jul 4, 2023 · 11 comments
Open

Allow password manager app to auto-fill the login form #89

marc-farre opened this issue Jul 4, 2023 · 11 comments
Labels
bug Something isn't working Platform: Android

Comments

@marc-farre
Copy link
Collaborator

On other apps or in the Browser, when clicking a field of the login form (username or password), the password manager adds a sort of modal box allowing to select the account to auto-fill the login form with:

image

Tested with Bitwarden only (maybe it works with others).

@luke-
Copy link
Collaborator

luke- commented Jul 4, 2023

Samsung Pass is working fine on my mobile.

image

@marc-farre
Copy link
Collaborator Author

marc-farre commented Oct 7, 2023

Update: If I go in the settings -> Accessibility -> Installed services -> Bitwarden and turn it to "on", the dropdown menu with Bitwarden appear on the login form (strangely this is not required for other apps and it's not the default setting).
But after clicking on the login/password pair of Bitwarden to autofill, the fields stay blank and I have the message "No password field detected".

@PrimozRatej
Copy link
Collaborator

Update: On the iOS it works as expected. Tested with Google password manager and Bitwarden. The problem persists on Android. Looking into it.

@marc-farre
Copy link
Collaborator Author

@PrimozRatej FYI, when I login on a Humhub instance via an SSO, when I'm on the SSO page (so I'm not in Humhub), Bitwarden autofill works with Android. So the problem is only on Humhub form.

@luke- luke- added bug Something isn't working Platform: Android and removed Need Investigation labels Jan 30, 2024
@PrimozRatej
Copy link
Collaborator

Hey @marc-farre, I found there's still an open issue regarding this in the flutter_inappwebView repo that we use for WebView. However, the actual bug might be within an official Flutter/engine issue. Although it has been merged, it doesn't seem like it has been released yet according to the Flutter release CHANGELOG. I'll upgrade Flutter to the latest version so we can test it.

@PrimozRatej
Copy link
Collaborator

PrimozRatej commented Aug 23, 2024

I updated the version of Flutter to the latest stable release f-flutter-upgrade-3.24.0, but it looks like everything is the same on this topic. It seems that they fixed the Google password manager autofill, but Bitwarden still doesn't work. At this point, I assume the problem is with the Bitwarden implementation for Android.

@marc-farre
Copy link
Collaborator Author

@PrimozRatej Thanks for trying. What's weird, is that it's the only app I have where Bitwarden doesn't work. It even works in small and not very well-known apps.

Maybe these links can help?

@PrimozRatej
Copy link
Collaborator

PrimozRatej commented Aug 23, 2024

The problem isn't with Flutter itself. If this were a native view, you would define a base URL environment and use [AutofillHints.email, AutofillHints.username] & [AutofillHints.password]. However, since we're running it inside a web view, an additional layer is added. It appears that Bitwarden's autofill implementation does not recognize those input fields or the envirionment itself. I assume it's one of those 2 things.

@marc-farre
Copy link
Collaborator Author

@PrimozRatej FYI, when I log in with an SSO (inside HumHub mobile app), Bitwarden works well.
So it seems to be possible to make it work.

@PrimozRatej
Copy link
Collaborator

PrimozRatej commented Sep 6, 2024

when I log in with an SSO (inside HumHub mobile app), Bitwarden works well.

@marc-farre - With which provider did you log in with, or does it not matter?

@marc-farre
Copy link
Collaborator Author

marc-farre commented Sep 6, 2024

Anyone. You can test here: https://community.humhub.com/dashboard

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Platform: Android
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants