Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In files tables - change icon "fa-unlock-alt" to "fa-unlock" #180

Closed
Gilbertdelyon opened this issue May 20, 2023 · 4 comments · Fixed by #183
Closed

In files tables - change icon "fa-unlock-alt" to "fa-unlock" #180

Gilbertdelyon opened this issue May 20, 2023 · 4 comments · Fixed by #183
Assignees

Comments

@Gilbertdelyon
Copy link

Gilbertdelyon commented May 20, 2023

I become old and my eyes are tired.
Please why are public files displayed with "fa-unlock-alt" icon in files tables.
I have to get close to the screen to check if it's lock or unlock.
I would highly prefer the usual simple "fa-unlock"

@Gilbertdelyon Gilbertdelyon changed the title In files table - change icon "fa-unlock-alt" to "fa-unlock" In files tables - change icon "fa-unlock-alt" to "fa-unlock" May 20, 2023
@luke-
Copy link
Contributor

luke- commented May 20, 2023

@Eladnarlea Can you please take a look into this. We should be consistent in terms of the icons.

@Eladnarlea
Copy link

Screenshot 2023-06-12 at 11 12 49 AM

@luke- it is actually quite inconsistent already. We use the fa-unlock in the menu to switch between private and public, but use the fa-unlock-alt within the list. Therefore changing the list icon to fa-unlock would be the right thing to do.

@Eladnarlea
Copy link

Screenshot 2023-06-12 at 11 15 48 AM

@yurabakhtin can you please change the fa-unlock-alt to fa-unlock in the files list?

@yurabakhtin
Copy link
Contributor

@luke- PR #183.

@yurabakhtin yurabakhtin linked a pull request Jun 13, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants