Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public folders in private spaces #190

Closed
Semir1212 opened this issue Aug 28, 2023 · 2 comments · Fixed by #192
Closed

Public folders in private spaces #190

Semir1212 opened this issue Aug 28, 2023 · 2 comments · Fixed by #192
Assignees
@yurabakhtin
Labels
bug

Comments

@Semir1212
Copy link
Contributor

HH 1.14.3
Files 0.16.1

image

  • Create private space
  • Create public folder
  • Upload file

Result: File can be found by non-members via search.

If a space is private the option should ideally be unavailable. In any case the space being private should overwrite the option of the module.
@luke-
Copy link
Contributor

luke- commented Aug 28, 2023

@yurabakhtin We should use the generic (core provided) checkbox field here.

@luke- luke- added the bug label Aug 28, 2023
@yurabakhtin yurabakhtin mentioned this issue Sep 4, 2023
Merged
@yurabakhtin yurabakhtin linked a pull request Sep 4, 2023 that will close this issue
Fix folder visibility in private space #192
Merged
@yurabakhtin
Copy link
Contributor

@luke- Fixed in PR #192.

@luke- luke- closed this as completed in #192 Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yurabakhtin yurabakhtin

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix folder visibility in private space humhub/cfiles
3 participants
@luke- @yurabakhtin @Semir1212