Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh: Add Cookie Policy page #34

Closed
wants to merge 7 commits into from

Conversation

ArchBlood
Copy link
Contributor

@ArchBlood ArchBlood commented Jul 23, 2021

Please review and see if this is something that should be added versus what shouldn't be added

fixes #21

Notes

I'd like to add once more for a note about mobile view vs desktop view seen here #21 (comment)

@ArchBlood
Copy link
Contributor Author

@luke- here's the rundown of the implementation of the Cookie Policy, it works just like other pages and is then added to the footer along with the other enabled options, personally, I'd rather implement it in a way where it only displays in a specific place but for now, this should do exactly what it's needed. 🤔

@ArchBlood ArchBlood changed the title Cookie Policy Enh: Add Cookie Policy page Jul 23, 2021
@luke- luke- requested a review from yurabakhtin July 23, 2021 20:45
@ArchBlood
Copy link
Contributor Author

A thought, instead of adding it to the footer section, maybe only display this on the Cookie notice?

@luke-
Copy link
Collaborator

luke- commented Oct 9, 2022

I would prefer to add such additional footer pages via the Custom Pages module instead of covering such cases via the Legal Pages module.

@ArchBlood
Copy link
Contributor Author

I would prefer to add such additional footer pages via the Custom Pages module instead of covering such cases via the Legal Pages module.

Hmm, in that case, would it be possible to implement such a thing into the footer though the custom pages module, currently I'm not seeing an option for this as of yet.

Overall the idea of placing a clickable link in the notice itself should still suffice. 🤔

@luke-
Copy link
Collaborator

luke- commented Oct 10, 2022

This option:
image

@ArchBlood
Copy link
Contributor Author

This option:
image

In this case, would it be possible to update the footer menu where it's implemented in a way similar to how Facebook has theirs? This could fix some of the UI downsides to adding multiple options to the footer.

@luke-
Copy link
Collaborator

luke- commented Oct 14, 2022

What downsides do you mean? If there are things to improve about the footer menu, we can create an issue.

@ArchBlood
Copy link
Contributor Author

On mobile view with multiple options in the footer it can become very cluttered and if too many links are placed then the display is very displeasing and looks stretched out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate Cookies Policy text
2 participants