-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enh: Add Cookie Policy page #34
Conversation
@luke- here's the rundown of the implementation of the Cookie Policy, it works just like other pages and is then added to the footer along with the other enabled options, personally, I'd rather implement it in a way where it only displays in a specific place but for now, this should do exactly what it's needed. 🤔 |
A thought, instead of adding it to the footer section, maybe only display this on the Cookie notice? |
I would prefer to add such additional footer pages via the Custom Pages module instead of covering such cases via the Legal Pages module. |
Hmm, in that case, would it be possible to implement such a thing into the footer though the custom pages module, currently I'm not seeing an option for this as of yet. Overall the idea of placing a clickable link in the notice itself should still suffice. 🤔 |
What downsides do you mean? If there are things to improve about the footer menu, we can create an issue. |
On mobile view with multiple options in the footer it can become very cluttered and if too many links are placed then the display is very displeasing and looks stretched out. |
Please review and see if this is something that should be added versus what shouldn't be added
fixes #21
Notes
I'd like to add once more for a note about mobile view vs desktop view seen here #21 (comment)