Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/XRPL connector 25 Feb Improvements #286

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Refactor/XRPL connector 25 Feb Improvements #286

merged 2 commits into from
Feb 27, 2024

Conversation

mlguys
Copy link
Contributor

@mlguys mlguys commented Feb 24, 2024 •
edited
Loading

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

  • Improve market info loading logic
  • Upgrade eslint and prettier version

Tests performed by the developer:

  • Run example scripts for XRPL connector in client script folder

Tips for QA testing:

@mlguys mlguys mentioned this pull request Feb 24, 2024
Closed
2 tasks
@fengtality fengtality merged commit 9e40cdd into development Feb 27, 2024
5 checks passed
@fengtality fengtality deleted the fix/xrpl-revert-submit-and-wait branch February 27, 2024 13:44
@notion-workspace Notion Workspace
Copy link

Make XRPL Connector response to requests faster

This was referenced Mar 18, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengtality fengtality fengtality approved these changes

@rapcmia rapcmia rapcmia approved these changes

@nikspz nikspz Awaiting requested review from nikspz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlguys @fengtality @rapcmia