Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hebrew translation in crowdin #418

Closed
Y-PLONI opened this issue Aug 23, 2024 · 7 comments
Closed

Add Hebrew translation in crowdin #418

Y-PLONI opened this issue Aug 23, 2024 · 7 comments
Labels
enhancement New feature or request l10n Localization

Comments

@Y-PLONI
Copy link

Y-PLONI commented Aug 23, 2024

Could you please add in crowdin an option to translate the app into Hebrew?
Thank you very much!
Your app is very beautiful!
I'm considering removing windows media player entirely!
@Y-PLONI Y-PLONI added the enhancement New feature or request label Aug 23, 2024
@Y-PLONI Y-PLONI changed the title Added Hebrew translation in crowdin Add Hebrew translation in crowdin Aug 23, 2024
@huynhsontung
Copy link
Owner

Thank you for your kind words! Hebrew has been added.

@huynhsontung huynhsontung added a11y Issues with navigation interactions, screen readers, contrast, text sizes and other areas l10n Localization and removed a11y Issues with navigation interactions, screen readers, contrast, text sizes and other areas labels Aug 24, 2024
@Y-PLONI
Copy link
Author

Y-PLONI commented Aug 25, 2024 •
edited
Loading

I translated a significant part of the software, I would be happy to check if there are any bugs due to the combination between Hebrew and English. You will be able to release a new version? [you can also release software with the same version number, so that the software is not updated for everyone, and only those who remove and install receive the update].

By the way, you can remind those who like the software to give you a star! I remembered to give you just now!

@Y-PLONI
Copy link
Author

Y-PLONI commented Aug 25, 2024 •
edited
Loading

I translated

@huynhsontung
I'm done, I can reach 100% only after I see the translation inside the software.
thanks!

@huynhsontung
Copy link
Owner

@Y-PLONI I have added some screenshots to help with the context. It should be good enough for a release as is. Thank you!

@iLiranS
Copy link

iLiranS commented Aug 26, 2024

Hi, the Hebrew version is broken, the videos are vertically flipped, the nav bar is broken as well (I guess it's about the RTL behavior). If possible, I would like an option to choose preferred language as well 😅

@Y-PLONI
Copy link
Author

Y-PLONI commented Aug 26, 2024

@iLiranS Right, I just saw that and will start another issue on it.
In my opinion, it is better to configure the software as if it were in English, with a Hebrew language file [most problems are caused by the definition that the application is in Hebrew, and not by the fact that the text displayed on the screen is in Hebrew]. I don't know if it's possible...

@Y-PLONI Y-PLONI mentioned this issue Aug 26, 2024
Open
@huynhsontung
Copy link
Owner

Hebrew translation has been added in #424 and subsequently #434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request l10n Localization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@huynhsontung @iLiranS @Y-PLONI