Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error installing while using Go Modules due to outdated dependency name #689

Closed
jshields opened this issue Sep 12, 2019 · 8 comments
Closed
Labels

Comments

@jshields
Copy link
Contributor

When installing using the instructions from https://gobot.io/ using Go 1.13 and Go Modules, an error occurs like so

~/workspace/dronez(master): go get -u gobot.io/x/gobot/...
...
go: github.com/codegangsta/[email protected]: parsing go.mod: unexpected module path "github.com/urfave/cli"
go: error loading module requirements

This is due to the usage of the dependency "github.com/codegangsta/cli", which has been renamed to "github.com/urfave/cli"

(See that https://github.com/codegangsta/cli redirects to https://github.com/urfave/cli)

"github.com/codegangsta/cli"

@deadprogram
Copy link
Member

Got it. Would you like to submit a PR that corrects this?

@jshields
Copy link
Contributor Author

@deadprogram Sure thing :) Gotta install dep to update the lock file, then I'll send that over.

@jshields
Copy link
Contributor Author

I opened #690
Feel free to suggest another version of dep I should use or different settings for generating the lock file.

@MShoaei
Copy link
Contributor

MShoaei commented Oct 1, 2019

This issue is kind of forgotten but maybe it's a good time to consider migrating to go modules. Also there are 2 dependencies that need to be fixed and the second one is in platform/nats. I have them fixed and also tried migrating to go modules and I'm ready to make the PR.
Just making sure if you want to consider migrating to go modules. Here's my repo if you want to check it out.

@jshields
Copy link
Contributor Author

jshields commented Oct 2, 2019

@MShoaei Agreed, moving to Go Modules is the long term solution.

@deadprogram
Copy link
Member

I have just merged the dep PR, and would gladly accept a PR to move to modules!

@deadprogram
Copy link
Member

The modules code is now in the `dev`` branch.

@deadprogram deadprogram added the interface-request things like new protocols and/or interfaces label Oct 15, 2019
@deadprogram
Copy link
Member

This has now been released. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants