From 6f212933734e2f3695c9d6c11825c5c80fbea8ac Mon Sep 17 00:00:00 2001
From: Caen De Silva <caen@desilva.se>
Date: Mon, 9 Sep 2024 10:55:11 +0200
Subject: [PATCH] Extract helper method to set up the mocks

---
 .../tests/Unit/BuildTaskServiceUnitTest.php   | 24 +++++++++++--------
 1 file changed, 14 insertions(+), 10 deletions(-)

diff --git a/packages/framework/tests/Unit/BuildTaskServiceUnitTest.php b/packages/framework/tests/Unit/BuildTaskServiceUnitTest.php
index ca381fe3d37..0ea55cd8935 100644
--- a/packages/framework/tests/Unit/BuildTaskServiceUnitTest.php
+++ b/packages/framework/tests/Unit/BuildTaskServiceUnitTest.php
@@ -207,7 +207,7 @@ public function testCanRunPostBuildTasksWithTasks()
 
     public function testRunPreBuildTasksCallsHandleMethods()
     {
-        $task = Mockery::mock(TestPreBuildTask::class)->makePartial()->shouldReceive('handle')->once()->getMock();
+        $task = $this->setupMock(TestPreBuildTask::class, 'handle')->getMock();
 
         $this->service->registerTask($task);
         $this->service->runPreBuildTasks();
@@ -215,7 +215,7 @@ public function testRunPreBuildTasksCallsHandleMethods()
 
     public function testRunPostBuildTasksCallsHandleMethods()
     {
-        $task = Mockery::mock(TestPostBuildTask::class)->makePartial()->shouldReceive('handle')->once()->getMock();
+        $task = $this->setupMock(TestPostBuildTask::class, 'handle')->getMock();
 
         $this->service->registerTask($task);
         $this->service->runPostBuildTasks();
@@ -223,7 +223,7 @@ public function testRunPostBuildTasksCallsHandleMethods()
 
     public function testRunPreBuildTasksCallsRunMethods()
     {
-        $task = Mockery::mock(TestPreBuildTask::class)->makePartial()->shouldReceive('run')->once()->getMock();
+        $task = $this->setupMock(TestPreBuildTask::class, 'run')->getMock();
 
         $this->service->registerTask($task);
         $this->service->runPreBuildTasks();
@@ -231,7 +231,7 @@ public function testRunPreBuildTasksCallsRunMethods()
 
     public function testRunPostBuildTasksCallsRunMethods()
     {
-        $task = Mockery::mock(TestPostBuildTask::class)->makePartial()->shouldReceive('run')->once()->getMock();
+        $task = $this->setupMock(TestPostBuildTask::class, 'run')->getMock();
 
         $this->service->registerTask($task);
         $this->service->runPostBuildTasks();
@@ -239,7 +239,7 @@ public function testRunPostBuildTasksCallsRunMethods()
 
     public function testRunPreBuildTasksCallsRunMethodsWithNullWhenServiceHasNoOutput()
     {
-        $task = Mockery::mock(TestPreBuildTask::class)->makePartial()->shouldReceive('run')->with(null)->once()->getMock();
+        $task = $this->setupMock(TestPreBuildTask::class, 'run')->with(null)->once()->getMock();
 
         $this->service->registerTask($task);
         $this->service->runPreBuildTasks();
@@ -247,7 +247,7 @@ public function testRunPreBuildTasksCallsRunMethodsWithNullWhenServiceHasNoOutpu
 
     public function testRunPostBuildTasksCallsRunMethodsWithNullWhenServiceHasNoOutput()
     {
-        $task = Mockery::mock(TestPostBuildTask::class)->makePartial()->shouldReceive('run')->with(null)->once()->getMock();
+        $task = $this->setupMock(TestPostBuildTask::class, 'run')->with(null)->once()->getMock();
 
         $this->service->registerTask($task);
         $this->service->runPostBuildTasks();
@@ -256,7 +256,7 @@ public function testRunPostBuildTasksCallsRunMethodsWithNullWhenServiceHasNoOutp
     public function testRunPreBuildTasksCallsRunMethodsWithOutputWhenServiceHasOutput()
     {
         $output = Mockery::mock(OutputStyle::class)->makePartial();
-        $task = Mockery::mock(TestPreBuildTask::class)->makePartial()->shouldReceive('run')->with($output)->once()->getMock();
+        $task = $this->setupMock(TestPreBuildTask::class, 'run')->with($output)->once()->getMock();
 
         $this->service->setOutput($output);
         $this->service->registerTask($task);
@@ -266,7 +266,7 @@ public function testRunPreBuildTasksCallsRunMethodsWithOutputWhenServiceHasOutpu
     public function testRunPostBuildTasksCallsRunMethodsWithOutputWhenServiceHasOutput()
     {
         $output = Mockery::mock(OutputStyle::class)->makePartial();
-        $task = Mockery::mock(TestPostBuildTask::class)->makePartial()->shouldReceive('run')->with($output)->once()->getMock();
+        $task = $this->setupMock(TestPostBuildTask::class, 'run')->with($output)->once()->getMock();
 
         $this->service->setOutput($output);
         $this->service->registerTask($task);
@@ -319,8 +319,7 @@ protected function createService(): BuildTaskService
 
     protected function mockKernelFilesystem(array $files = []): void
     {
-        $filesystem = Mockery::mock(Filesystem::class, [HydeKernel::getInstance()])
-            ->makePartial()->shouldReceive('smartGlob')->once()
+        $filesystem = $this->setupMock(Filesystem::class, 'smartGlob')
             ->with('app/Actions/*BuildTask.php', 0)
             ->andReturn(collect($files))->getMock();
 
@@ -332,6 +331,11 @@ protected function resetKernelInstance(): void
     {
         HydeKernel::setInstance(new HydeKernel());
     }
+
+    protected function setupMock(string $class, string $method): Mockery\ExpectationInterface|Mockery\Expectation|Mockery\HigherOrderMessage
+    {
+        return Mockery::mock($class)->makePartial()->shouldReceive($method)->once();
+    }
 }
 
 class InstantiableTestBuildTask extends BuildTask