From ce34eecb6dfe2c72412c4b5cb9857cf165f2e262 Mon Sep 17 00:00:00 2001 From: Caen De Silva Date: Fri, 28 Jun 2024 16:54:27 +0200 Subject: [PATCH 1/2] Remove the deprecated global `unslash` function --- packages/framework/src/helpers.php | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/packages/framework/src/helpers.php b/packages/framework/src/helpers.php index 73be251439e..34e8f9da12b 100644 --- a/packages/framework/src/helpers.php +++ b/packages/framework/src/helpers.php @@ -4,7 +4,6 @@ namespace { use Hyde\Foundation\HydeKernel; - use JetBrains\PhpStorm\Deprecated; if (! function_exists('hyde')) { /** @@ -16,21 +15,6 @@ function hyde(): HydeKernel } } - if (! function_exists('unslash')) { - /** - * Remove trailing slashes from the start and end of a string. - * - * @deprecated This function will be replaced by {@see \Hyde\unslash()} in v2.0 - * - * @codeCoverageIgnore This function is deprecated and will be removed in a future release. - */ - #[Deprecated(reason: 'Replaced by the \Hyde\unslash() function', replacement: '\Hyde\unslash(%parametersList%)', since: '1.7.0')] - function unslash(string $string): string - { - return \Hyde\unslash($string); - } - } - if (defined('HYDE_COMPATIBILITY_MODE') && HYDE_COMPATIBILITY_MODE === true) { // Don't declare these functions when running in compatibility mode. } else { From 8a1e57f7be88e2461361d58be3b4cd0afab2c719 Mon Sep 17 00:00:00 2001 From: Caen De Silva Date: Fri, 28 Jun 2024 16:55:46 +0200 Subject: [PATCH 2/2] Update RELEASE_NOTES.md --- RELEASE_NOTES.md | 1 + 1 file changed, 1 insertion(+) diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 0b412158291..48d8030036e 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -44,6 +44,7 @@ This serves two purposes: ### Removed - Breaking: Removed the build task `\Hyde\Framework\Actions\PostBuildTasks\GenerateSearch` (see upgrade guide below) - Breaking: Removed the deprecated `\Hyde\Framework\Services\BuildService::transferMediaAssets()` method (see upgrade guide below) +- Internal: Removed the deprecated global`unslash()` function, replaced with the namespaced `\Hyde\unslash()` function in https://github.com/hydephp/develop/pull/1754 - Internal: Removed the internal `DocumentationSearchPage::generate()` method as it was unused in https://github.com/hydephp/develop/pull/1569 ### Fixed