Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyfetch assumes config is writeable when adding 'pride animation shown' flag #136

Closed
1 task done
Aleksanaa opened this issue Jun 10, 2023 · 1 comment
Closed
1 task done

Comments

@Aleksanaa
Copy link

Describe the bug

Hyfetch now displays an animation at the first start, and tries to add a flag to the config saying that it is shown.

config.pride_month_shown.append(now.year)

It may appear to be reasonable, but what if you are using home-manager? The config is just a symlink pointing to the read-only Nix store. If you tries to write to it, you'll fail, and if you choose to override it, home-manager will fail to deploy the next time.

  • Does this issue still occur in the master branch? (Required)

Expected behavior

So just don't touch the config. If the config already exists, leave it there. And if we want to persist any state, just place it in xdg cache.

Additional context

Add any other context about the problem here.

hykilpikonna added a commit that referenced this issue Jun 15, 2023
@hykilpikonna
Copy link
Owner

Thanks for reporting the issue! It will create a file $XDG_CACHE_HOME/hyfetch/animation-displayed-{year} instead of writing the config from now on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants