Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace HttpTryFrom with std::convert::TryFrom #317

Closed
seanmonstar opened this issue May 30, 2019 · 3 comments
Closed

Replace HttpTryFrom with std::convert::TryFrom #317

seanmonstar opened this issue May 30, 2019 · 3 comments
Labels
B-breaking Blocked: breaking change. This requires a breaking change. E-easy Effort: easy. Start here :D
Milestone
0.2

Comments

@seanmonstar
Copy link
Member

No description provided.

@seanmonstar seanmonstar added E-easy Effort: easy. Start here :D B-breaking Blocked: breaking change. This requires a breaking change. labels May 30, 2019
@seanmonstar seanmonstar added this to the 0.2 milestone May 30, 2019
@seanmonstar seanmonstar mentioned this issue May 30, 2019
Closed
@lovasoa
Copy link
Contributor

lovasoa commented Jul 2, 2019

Would it be possible to implement TryFrom for all types that implement HttpTryFrom without breaking backward compatibility, using conditional compilation ?

https://dev.to/jeikabu/rust-tryfrom-and-conditional-compilation-46fe

@seanmonstar
Copy link
Member Author

@lovasoa it's possible! We're just moving towards 0.2 already, and in that branch, we don't need to support the older compiler. See #308 (comment)

@seanmonstar
Copy link
Member Author

Completed in the 0.2.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-breaking Blocked: breaking change. This requires a breaking change. E-easy Effort: easy. Start here :D
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
2 participants
@seanmonstar @lovasoa