Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove record_header_indices split loop for ARM #1672

Closed
seanmonstar opened this issue Oct 16, 2018 · 1 comment · Fixed by #2041
Closed

Remove record_header_indices split loop for ARM #1672

seanmonstar opened this issue Oct 16, 2018 · 1 comment · Fixed by #2041
Labels
A-http1 Area: HTTP/1 specific. C-performance Category: performance. This is making existing behavior go faster. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Milestone
0.13

Comments

@seanmonstar
Copy link
Member

A rustc/LLVM bug was preventing compilation on ARMv7, due to some legal Rust code in proto::h1::role::record_header_indices. A workaround splitting the loop into 2 loops was added in #1671.

The bug in rustc is tracked here: rust-lang/rust#55105. Once it is fixed (and available on stable), this workaround should be removed.
@seanmonstar seanmonstar added C-performance Category: performance. This is making existing behavior go faster. E-easy Effort: easy. A task that would be a great starting point for a new contributor. B-upstream Blocked: needs a change in a dependency or the compiler. labels Oct 16, 2018
@seanmonstar seanmonstar added the A-http1 Area: HTTP/1 specific. label Jan 24, 2019
@seanmonstar
Copy link
Member Author

I'd prefer to remove this soon-ish, though it seems there's been no progress on the upstream bug. Either others who need it can chime in there, or I'll assume the need is no longer there.

@seanmonstar seanmonstar added this to the 0.13 milestone Oct 18, 2019
@seanmonstar seanmonstar removed the B-upstream Blocked: needs a change in a dependency or the compiler. label Oct 18, 2019
@seanmonstar seanmonstar mentioned this issue Dec 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-http1 Area: HTTP/1 specific. C-performance Category: performance. This is making existing behavior go faster. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Milestone
0.13
Development

Successfully merging a pull request may close this issue.

refactor(h1): un-split record_header_indicies for ARM hyperium/hyper
1 participant
@seanmonstar