Access-Control-Allow-Credentials header

[fuchsnj]

the Access-Control-Allow-Credentials header is missing

http://www.w3.org/TR/2008/WD-access-control-20080912/#access-control-allow-credentials

ABNF:

Access-Control-Allow-Credentials: "Access-Control-Allow-Credentials" ":" "true"

[brycefisher]

I'd like to tackle this one.

I started looking at the spec, and I realized there is only ever one valid value for this header. For example, this value could never be false.

Given that invariant, I would probably want users to set this header without needing to pass in a bool. Ex:

extern crate hyper;

use hyper::header::{Headers, AccessControlAllowCredentials};

fn main() {
    let mut headers = Headers::new();
    headers.set(AccessControlAllowCredentials);
}

However, we probably would want to parse raw AccessControlAllowCredentials headers values of any case. For example an HTTP client should probably still parse this sort of response:

HTTP/1.1 200 OK
AccessControlAllowCredentials:TrUE
...

[brycefisher]

Can't get tests to pass tonight...trying tomorrow:
https://github.com/brycefisher/hyper/commit/29c33f59586976ac87b8de1c38bcc48e89d4dcc8

[brycefisher]

Gave up on any casing

[Ryman]

@brycefisher You should be able to replicate something like this

hyper/src/header/common/expect.rs

Line 47 in 388ddf6

if UniCase(text) == EXPECT_CONTINUE {

Good luck!

[brycefisher]

@Ryman oh nice, that's exactly what I was looking for!