Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codec): Cancelled client streaming handling #1315

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

LucioFranco
Copy link
Member

This PR fixes how client side streaming is handled on the server side and improves overall source error matching.

Fixes:

  • Correctly, detect h2 codes when its wrapped in a hyper error.
  • Cancelled requests from the client side during client streaming requests correctly return EOF (None from Streaming::message())

Closes #848

This PR fixes how client side streaming is handled on the server side
and improves overall source error matching.

Fixes:

- Correctly, detect h2 codes when its wrapped in a hyper error.
- Cancelled requests from the client side during client streaming
  requests correctly return EOF (`None` from `Streaming::message()`)

Closes #848
@LucioFranco LucioFranco added this pull request to the merge queue Mar 14, 2023
Merged via the queue into master with commit c8027a1 Mar 14, 2023
@LucioFranco LucioFranco deleted the lucio/fix-client-cancel-streaming branch March 14, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improper error handling with from h2 reason::cancel -> tonic::code::unkown
1 participant