Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codec): Make error when not utf8 value in compression encoding #1768

Conversation

tottoto
Copy link
Collaborator

@tottoto tottoto commented Jul 1, 2024

Makes error in the case when not utf8 value is in the compression encoding.

@tottoto tottoto force-pushed the make-error-when-not-utf8-value-in-compression-encoding branch 3 times, most recently from 6b4fccd to dc0f9d0 Compare July 2, 2024 14:13
Copy link
Collaborator

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

tonic/src/codec/compression.rs Outdated Show resolved Hide resolved
@tottoto tottoto force-pushed the make-error-when-not-utf8-value-in-compression-encoding branch from dc0f9d0 to 16973d3 Compare July 3, 2024 14:07
tonic/src/codec/compression.rs Outdated Show resolved Hide resolved
@tottoto tottoto force-pushed the make-error-when-not-utf8-value-in-compression-encoding branch from 16973d3 to 249f138 Compare July 3, 2024 14:30
@tottoto tottoto added this pull request to the merge queue Jul 6, 2024
Merged via the queue into hyperium:master with commit f8e1f87 Jul 6, 2024
16 checks passed
@tottoto tottoto deleted the make-error-when-not-utf8-value-in-compression-encoding branch July 6, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants