Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tonic): Add Request::set_timeout #615

Merged
merged 2 commits into from
Apr 29, 2021
Merged

feat(tonic): Add Request::set_timeout #615

merged 2 commits into from
Apr 29, 2021

Conversation

davidpdrsn
Copy link
Member

This will set the grpc-timeout to a value formatted according to the spec.

LucioFranco
LucioFranco approved these changes Apr 29, 2021
View reviewed changes
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So slick!

@davidpdrsn davidpdrsn merged commit dae31d0 into master Apr 29, 2021
@davidpdrsn davidpdrsn deleted the david/request-set-deadline branch April 29, 2021 13:59
@davidpdrsn davidpdrsn mentioned this pull request Apr 29, 2021
Merged
@BohuTANG BohuTANG mentioned this pull request Apr 30, 2021
Closed
@liufuyang
Copy link
Contributor

Aha, this is very nice to have, thank you very much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucioFranco LucioFranco LucioFranco approved these changes

Assignees
No one assigned
Labels
A-tonic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidpdrsn @liufuyang @LucioFranco