Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(build): ensure foundry build dependency is documented #3583

Open
petermetz opened this issue Oct 10, 2024 · 1 comment
Open

docs(build): ensure foundry build dependency is documented #3583

petermetz opened this issue Oct 10, 2024 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation IETF-SATP-Hermes Related to the Secure Asset Transfer Protocol as defined by the Internet Engineering Task Force.

Comments

@petermetz
Copy link
Contributor

Description

On the satp-dev branch you can't run yarn install successfully unless foundry is installed on the computer prior to it.
This is an undocumented build dependency at the moment as far as I know so opened this issue to keep track.

# This file contains the result of Yarn building a package (@hyperledger/cactus-plugin-satp-hermes@workspace:packages/cactus-plugin-satp-hermes)
# Script name: preinstall

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   167  100   167    0     0    939      0 --:--:-- --:--:-- --:--:--   943

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  2189  100  2189    0     0   3976      0 --:--:-- --:--:-- --:--:-- 12952
Installing foundryup...

Detected your preferred shell is bash and added foundryup to PATH.
Run 'source /home/someone/.bashrc' or start a new terminal session to use foundryup.
Then, simply run 'foundryup' to install Foundry.
command not found: foundryup

Acceptance Criteria

  1. The documentation accurately reflects all build dependencies so that people can

cc: @RafaelAPB

@petermetz petermetz added documentation Improvements or additions to documentation IETF-SATP-Hermes Related to the Secure Asset Transfer Protocol as defined by the Internet Engineering Task Force. labels Oct 10, 2024
@petermetz petermetz self-assigned this Oct 10, 2024
@RafaelAPB
Copy link
Contributor

@petermetz thank you for taking care of this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation IETF-SATP-Hermes Related to the Secure Asset Transfer Protocol as defined by the Internet Engineering Task Force.
Projects
None yet
Development

No branches or pull requests

2 participants