Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky tests #359

Open
mbrandenburger opened this issue Aug 5, 2022 · 1 comment
Open

Fix flaky tests #359

mbrandenburger opened this issue Aug 5, 2022 · 1 comment
Labels
testing All related to testing

Comments

@mbrandenburger
Copy link
Member

Some tests seem to be flaky, such as the FPC integration test.

  • Short-term solution:
    Upgrade to ginkgo v2 as proposed in Upgrade ginkgo to v2 #331 and add ginkgo --flake-attempts=N to the corresponding make target of our flaky candidate.

  • Long-term:
    Investigate what is wrong and provide a proper fix.
@mbrandenburger mbrandenburger added the testing All related to testing label Aug 5, 2022
@mbrandenburger
Copy link
Member Author

mbrandenburger commented Aug 29, 2022 •
edited
Loading

PR 375 disables integration/nwo/fsc/tracing/aggregator_test.go temporary.

That unit test may be written using gingko.

@mbrandenburger mbrandenburger mentioned this issue Aug 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing All related to testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbrandenburger