Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTLC Enhancements #334

Open
5 of 8 tasks
HagarMeir opened this issue Aug 3, 2022 · 0 comments
Open
5 of 8 tasks

HTLC Enhancements #334

HagarMeir opened this issue Aug 3, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request interoperability

Comments

@HagarMeir
Copy link
Contributor

HagarMeir commented Aug 3, 2022

  • We have action Signature to carry the Claim Preimage. Action is reserved for tms actions (issue, transfer and setup). Signature itself is not an action. I see that having it this way allows for an easy lookup of preimages, but we could probably find another way, using TransferAction.GetMetadata() instead.
  • Review the terms of an exchange before accepting.
  • How are these new operations tracked in the transaction db token/services/ttxdb. Recall that the auditors and each participants in the assembling of the transaction store traces in the transaction db.
  • Is the auditor able to audit the script? need code in integration/token/interop/views/auditor.go for that.
  • How can the auditor track current holding when scripts are involved?
  • Is the acceptor able to inspect the script? maybe add code to integration/token/interop/views/htlc/lock.go.
  • ScanForPreImage actually works only when the backed is Fabric. But it should be backed agnostic by using the Network API (token/services/network).
  • Extend all interop integration tests to orion
@HagarMeir HagarMeir linked a pull request Aug 17, 2022 that will close this issue
@HagarMeir HagarMeir removed a link to a pull request Aug 22, 2022
@adecaro adecaro added enhancement New feature or request interoperability labels Sep 14, 2022
@adecaro adecaro changed the title HTLC suggestions HTLC Enhacements Sep 16, 2022
@adecaro adecaro changed the title HTLC Enhacements HTLC Enhancements Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request interoperability
Projects
None yet
Development

No branches or pull requests

2 participants