Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anoncreds): add anoncreds registry service #1204

Merged

Conversation

TimoGlastra
Copy link
Contributor

Fixes #1123, and adds the initial structure for the AnonCredsModule

@TimoGlastra TimoGlastra requested a review from a team as a code owner January 11, 2023 11:20
@TimoGlastra
Copy link
Contributor Author

Thinking whether we should rename supportedMethods to supportedIdentifiers in the AnonCredsRegistry interface, as we're not really filtering based on method, but rather on the structure of the identifier

Copy link
Contributor

@berendsliedrecht berendsliedrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of notes, nothing major.

TimoGlastra and others added 2 commits January 11, 2023 23:00
…try.ts

Co-authored-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2023

Codecov Report

Merging #1204 (c93dab8) into main (8a04d1b) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1204      +/-   ##
==========================================
- Coverage   87.63%   87.60%   -0.03%     
==========================================
  Files         726      731       +5     
  Lines       17350    17383      +33     
  Branches     2927     2928       +1     
==========================================
+ Hits        15204    15228      +24     
- Misses       2004     2013       +9     
  Partials      142      142              
Impacted Files Coverage Δ
packages/anoncreds/src/AnonCredsModule.ts 100.00% <100.00%> (ø)
packages/anoncreds/src/AnonCredsModuleConfig.ts 100.00% <100.00%> (ø)
packages/anoncreds/src/error/AnonCredsError.ts 100.00% <100.00%> (ø)
packages/anoncreds/src/error/index.ts 100.00% <100.00%> (ø)
.../src/services/registry/AnonCredsRegistryService.ts 100.00% <100.00%> (ø)
...ckages/indy-sdk/src/anoncreds/utils/identifiers.ts 100.00% <100.00%> (ø)
packages/core/src/agent/Dispatcher.ts 78.26% <0.00%> (-17.40%) ⬇️
packages/core/src/storage/IndyStorageService.ts 94.57% <0.00%> (-0.78%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TimoGlastra TimoGlastra enabled auto-merge (squash) January 12, 2023 10:18
@TimoGlastra TimoGlastra merged commit 86647e7 into openwallet-foundation:main Jan 12, 2023
NB-MikeRichardson added a commit to NB-MikeRichardson/aries-framework-javascript that referenced this pull request Jan 12, 2023
feat(anoncreds): add anoncreds registry service (openwallet-foundation#1204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create AnonCreds service that can handle multiple AnonCredsRegistries
3 participants