Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(indy-vdr): role property not included in nym request #1488

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

auer-martin
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2023

Codecov Report

Merging #1488 (ec7f126) into main (38a0578) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1488      +/-   ##
==========================================
- Coverage   85.81%   85.79%   -0.03%     
==========================================
  Files         943      943              
  Lines       22578    22588      +10     
  Branches     3911     3685     -226     
==========================================
+ Hits        19376    19380       +4     
- Misses       3021     3200     +179     
+ Partials      181        8     -173     
Impacted Files Coverage Δ
...kages/indy-vdr/src/dids/IndyVdrIndyDidRegistrar.ts 97.81% <ø> (+1.45%) ⬆️

... and 69 files with indirect coverage changes

@TimoGlastra
Copy link
Contributor

@2mau the commit does not seem to be signed off, can you sign of your commit?

fix: function is called with role

fix: function is called with role

fix: add role to tests
Signed-off-by: Martin Auer <[email protected]>
@TimoGlastra TimoGlastra merged commit 002be4f into openwallet-foundation:main Jul 6, 2023
@auer-martin auer-martin deleted the fix/nym branch December 4, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants