fix: do not send package via outdated session #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niall Shaw <[email protected]>
TimoGlastra
reviewed
Aug 29, 2023
| return Object.values(this.transportSessionTable).filter( | ||
| (session) => session?.connectionId === connectionId && session.type === 'WebSocket' | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe we can limit it to one session per type and connection id? That way we don't have to add web socket specific logic?
There was a problem hiding this comment.
Yeah, I'm happy with that also. Bug was only found in WebSocket, that's why I made it this way, but happy to change :)
|
FYI - this bug was found using AFJ 0.3.3, so perhaps it is not relevant anymore, but I can't see why it wouldn't be. |
Signed-off-by: Niall Shaw <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1559 +/- ##
=======================================
Coverage 85.73% 85.73%
=======================================
Files 950 950
Lines 22745 22753 +8
Branches 3978 3981 +3
=======================================
+ Hits 19500 19508 +8
Misses 3060 3060
Partials 185 185
|
|
@TimoGlastra - adjusted for any type |
niall-shaw
changed the title
genaris
approved these changes
Aug 29, 2023
ericvergnaud
pushed a commit
to Pocket-Developers/aries-framework-javascript
that referenced
this pull request
Sep 15, 2023
…1559) Signed-off-by: Niall Shaw <[email protected]> Signed-off-by: Eric Vergnaud <[email protected]>
genaris
pushed a commit
to genaris/credo-ts
that referenced
this pull request
Sep 22, 2023
…1559) Signed-off-by: Niall Shaw <[email protected]> Signed-off-by: Ariel Gentile <[email protected]>
auer-martin
pushed a commit
to auer-martin/aries-framework-javascript
that referenced
this pull request
Nov 15, 2023
…1559) Signed-off-by: Niall Shaw <[email protected]> Signed-off-by: Martin Auer <[email protected]>
auer-martin
pushed a commit
to auer-martin/aries-framework-javascript
that referenced
this pull request
Dec 4, 2023
…1559) Signed-off-by: Niall Shaw <[email protected]> Signed-off-by: Martin Auer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found an edge-case where a websocket transport session would be closed/unavailable on the client agent side, but mediator still thinks it is available (due to client being offline).
When client returns back online and initiates a flow via mediator, the mediator will attempt to send the package to the now outdated websocket, instead of the newest / current session.
This PR fixes the problem, but is there any reason why a single connection may need multiple open WebSocket transport sessions?