Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split libvcx crate #700

Closed
Patrik-Stas opened this issue Dec 17, 2022 · 1 comment
Closed

Split libvcx crate #700

Patrik-Stas opened this issue Dec 17, 2022 · 1 comment
Assignees

Comments

@Patrik-Stas
Copy link
Contributor

Split libvcx in 2 crates

  • libvcx_core - this would be today's "handle" layer of libvcx
  • libvcx - this would be today's api_c later of libvcx, eg built on top of libvcx_core crate

This will enable building different FFI approaches on shared base layer, ruling out a chance of dealing with some c symbol conflicts. For example we can build new libvcx_napi on top of libvcx_core as initiated in this PR #665
Similarly per @dinbtechit question #669 this would enable writing new wrappers, like flutter, with relative ease.

Implementation of this should have no breaking changes and the split should be invisible to the currently built libvcx dynamic library

@Patrik-Stas
Copy link
Contributor Author

libvcx was not split, but separated in 2 submodules api_c, api_vcx, see #710

@Patrik-Stas Patrik-Stas self-assigned this Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

1 participant