Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop the block synchronization after the first finalized block #3943

Closed
fab-10 opened this issue Jun 7, 2022 · 1 comment · Fixed by #3944 or #4058
Closed

Stop the block synchronization after the first finalized block #3943

fab-10 opened this issue Jun 7, 2022 · 1 comment · Fixed by #3944 or #4058
Assignees
Labels

Comments

@fab-10
Copy link
Contributor

fab-10 commented Jun 7, 2022

Description

The Merge spec says that an execution should behave like this after the switch to PoS:

Beginning with receiving the finalized block next to the FIRST_FINALIZED_BLOCK, the networking stack MUST remove the handlers corresponding to the following messages:

NewBlockHashes (0x01)
NewBlock (0x07)
Peers that keep sending these messages after the handlers have been removed SHOULD be disconnected.

currently Besu stop any block synchronization task when the TTD is reached, so it is not following the spec, and doing so is not able to easily recognize if a peer is still on PoW after TTD has been reached, and disconnect those peers.

Acceptance Criteria

Keep processing and sending

  • NewBlockHashes (0x01)
  • NewBlock (0x07)
    messages until the first finalized block is received from the CL

Versions (Add all that apply)

  • Software version: besu-22.4.3-SNAPSHOT
@fab-10 fab-10 self-assigned this Jun 7, 2022
@fab-10 fab-10 added the mainnet label Jun 7, 2022
@jflo jflo assigned jflo and unassigned fab-10 Jun 7, 2022
@jflo jflo mentioned this issue Jun 7, 2022
2 tasks
@jflo jflo closed this as completed in #3944 Jun 8, 2022
@jflo
Copy link
Contributor

jflo commented Jul 1, 2022

PR 3944 has been reverted, re-opening issue.

@jflo jflo reopened this Jul 1, 2022
@jflo jflo reopened this Jul 27, 2022
@jflo jflo closed this as completed Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants