Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Free Gas Network Configuration #4053

Closed
siladu opened this issue Jul 5, 2022 · 1 comment
Closed

Simplify Free Gas Network Configuration #4053

siladu opened this issue Jul 5, 2022 · 1 comment
Labels
enhancement New feature or request TeamGroot GH issues worked on by Groot Team

Comments

@siladu
Copy link
Contributor

siladu commented Jul 5, 2022

This PR was recently merged #4003

However the end result is a clunky UX for configuring gas free networks. It would be good to get this right before updating the documentation: https://besu.hyperledger.org/en/stable/HowTo/Configure/FreeGas/#3-start-besu-with-a-minimum-gas-price-of-zero

It would be good to make this simpler and more explicit, e.g. a single config parameter that replaces these two:
--min-gas-price=0 --override-genesis-config="baseFeePerGas=0x0"

For example --zero-price-gas or --free-gas.

One approach would be to have this new parameter simply set the other two under the hood.


UPDATE: the approach below is being looked at as a spike, #4067, so could do the simpler approach above as a quick win that could then be documented. The new cli flag could be reused for the approach below.

Another would be to replace LondonFeeMarket with a ZeroFeeMarket (or just wire up LegacyFeeMarket instead?)

Switching out the fee market seems cleaner and may solve this network upgrade issue, but it may be a lot more error prone than just zeroing the baseFee, since certain "London behaviour" may assume the baseFee is present.

@siladu
Copy link
Contributor Author

siladu commented Jul 20, 2022

Config changes will now be part of #4061

@siladu siladu closed this as completed Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request TeamGroot GH issues worked on by Groot Team
Projects
None yet
Development

No branches or pull requests

1 participant