Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should publicKey and raw fields be in eth_getBlockByNumber result #4503

Closed
macfarla opened this issue Oct 10, 2022 · 0 comments · Fixed by #4575
Closed

Should publicKey and raw fields be in eth_getBlockByNumber result #4503

macfarla opened this issue Oct 10, 2022 · 0 comments · Fixed by #4575
Assignees
Labels
mainnet RPC TeamRevenant GH issues worked on by Revenant Team

Comments

@macfarla
Copy link
Contributor

See #4490 for more context

Geth does not include these fields, however besu includes publicKey and raw fields in the "transactions" response for eth_getBlockByNumber/Hash

  • should they be included anyway - extra info
  • should any docs or spec need updating?
  • document why we include these extra fields
	     "transactions": [
       0: {
         "blockHash": "0x2ce0e9a8a0b33d45aeb70cf6878d2943deddcf6600e06b84546eaf0a0d2b9643",
         "blockNumber": "0x1",
         "chainId": "0x539",
         "from": "0x658bdf435d810c91414ec09147daa6db62406379",
         "gas": "0x5208",
         "gasPrice": "0x342770c1",
         "hash": "0x74e41d593675913d6d5521f46523f1bd396dff1891bdb35f59be47c7e5e0b34b",
         "input": "0x",
         "nonce": "0x0",
-        "publicKey": "0xd9a872707aaec451b19445dd00c5ad619f36a0dcad5b035b03baf16849f719e806455742d05bf26ab4d0e715198709e0e7794c214ccde55731a9fbbd51edf2d8",
         "r": "0xaf5fc351b9e457a31f37c84e5cd99dd3c5de60af3de33c6f4160177a2c786a60",
-        "raw": "0xf8678084342770c182520894658bdf435d810c91414ec09147daa6db624063798203e880820a95a0af5fc351b9e457a31f37c84e5cd99dd3c5de60af3de33c6f4160177a2c786a60a0201da7a21046af55837330a2c52fc1543cd4d9ead00ddf178dd96935b607ff9b",
         "s": "0x201da7a21046af55837330a2c52fc1543cd4d9ead00ddf178dd96935b607ff9b",
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mainnet RPC TeamRevenant GH issues worked on by Revenant Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants