Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configurable range for eth_getLogs RPC #4563

Closed
mark-terry opened this issue Oct 26, 2022 · 1 comment
Closed

Add configurable range for eth_getLogs RPC #4563

mark-terry opened this issue Oct 26, 2022 · 1 comment
Assignees
@mark-terry
Labels
mainnet RPC TeamRevenant GH issues worked on by Revenant Team

Comments

@mark-terry
Copy link
Contributor

Description

eth_getLogs default fromBlock from value is the genesis block. This leads to large default queries that can block the client.

A configurable maximum range parameter (something like --rpc-logs-range-upper-bound?) might reduce the chances of this happening.

Addresses part of #4123.

Acceptance Criteria

A configurable range to limit eth_getLogs query size is available.
@mark-terry mark-terry mentioned this issue Oct 26, 2022
Open
@mark-terry mark-terry added the TeamRevenant GH issues worked on by Revenant Team label Oct 26, 2022
@mark-terry mark-terry self-assigned this Oct 30, 2022
@iamhsk iamhsk added the doc-change-required Indicates an issue or PR that requires doc to be updated label Nov 22, 2022
@mark-terry
Copy link
Contributor Author

mark-terry commented Nov 28, 2022 •
edited
Loading

Some data on eth_getLogs output from Mainnet:
1000 block range: ~200Mb output, ~1s processing time
2000 block range: ~400Mb output, ~1.2s processing time
5000 block range: ~1.2Gb output, ~4.5s processing time.

@alexandratran alexandratran removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mark-terry mark-terry

Labels
mainnet RPC TeamRevenant GH issues worked on by Revenant Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iamhsk @alexandratran @mark-terry