Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shanghaiTime to ForkId #4793

Closed
siladu opened this issue Dec 8, 2022 · 1 comment
Closed

Add shanghaiTime to ForkId #4793

siladu opened this issue Dec 8, 2022 · 1 comment
Assignees
@jframe
Labels
EIP Ethereum Improvement Proposal TeamGroot GH issues worked on by Groot Team

Comments

@siladu
Copy link
Contributor

siladu commented Dec 8, 2022 •
edited
Loading

Spec: ethereum/EIPs#6122

ForkId implementation should include timestamps in the CRC calculation and the next value is the timestamp of the next fork.

This is based on geth's impl: ethereum/go-ethereum#25878
...this PR includes test cases with the expected hashes that we can borrow for ours too :)

Relevant test classes are ForkIdsTest.java and EIP2124Test.java.

This issue is a follow on from #4743 which was getting too big already.
@siladu siladu added the TeamGroot GH issues worked on by Groot Team label Dec 8, 2022
This was referenced Dec 8, 2022
Closed
Merged
@siladu siladu assigned gfukushima and jframe and unassigned gfukushima Dec 9, 2022
@siladu
Copy link
Contributor Author

siladu commented Dec 13, 2022

First pass impl: 9e8243c

@siladu siladu mentioned this issue Dec 14, 2022
Closed
2 tasks
@siladu siladu changed the title Add shanghaiTimestamp to ForkId Add shanghaiTime to ForkId Dec 14, 2022
@siladu siladu mentioned this issue Dec 22, 2022
Merged
2 tasks
@siladu siladu closed this as completed Dec 22, 2022
@non-fungible-nelson non-fungible-nelson added the EIP Ethereum Improvement Proposal label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jframe jframe

Labels
EIP Ethereum Improvement Proposal TeamGroot GH issues worked on by Groot Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jframe @siladu @gfukushima @non-fungible-nelson